Skip to content

refactor: use new React context API #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Dec 8, 2021
Merged

refactor: use new React context API #1948

merged 14 commits into from
Dec 8, 2021

Conversation

damianstasik
Copy link
Contributor

@damianstasik damianstasik commented Dec 5, 2021 •
edited
Loading

New Pull Request Checklist

Issue Description

This PR refactors the code that uses the legacy context API.

Related issue: #1950

Approach

  • Look for all contextTypes properties and replace them with contextType class property
  • Refactor generatePath to be a pure function
  • Refactor subscribeTo HOC to be a functional component to have better control when context (current app) changes
  • A few changes in some components to make them work with the new context API

TODOs before merging

  • Fix issue with browser table not reloading when changing class
  • Refactor the code to use new context API
  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

parse-github-assistant bot commented Dec 5, 2021 •
edited
Loading

Thanks for opening this pull request!

  • 🎉 We are excited about your hands-on contribution!

@damianstasik damianstasik marked this pull request as ready for review December 7, 2021 21:47
@damianstasik damianstasik requested a review from mtrezza December 7, 2021 21:47
mtrezza
mtrezza approved these changes Dec 8, 2021
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, that's quite an amazing PR!

@mtrezza mtrezza merged commit 1ff1057 into parse-community:alpha Dec 8, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-alpha.5

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Dec 12, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 1, 2022
@404-html
Copy link
Member

Cześć @visualfanatic, QQ: do you have an idea what could go wrong here? #1991

@mtrezza mtrezza mentioned this pull request Jan 22, 2022
Closed
4 tasks
damianstasik pushed a commit to damianstasik/parse-dashboard that referenced this pull request Jan 22, 2022
@visualfanatic
fix: regressions caused by parse-community#1948 and parse-community#1866
13fe3d3
@damianstasik damianstasik mentioned this pull request Jan 22, 2022
Merged
5 tasks
@mtrezza mtrezza mentioned this pull request Jan 23, 2022
Closed
4 tasks
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Feb 6, 2022
beiguancyc pushed a commit to beiguancyc/parse-dashboard that referenced this pull request Feb 8, 2022
@cycqitianwushuge
Merge branch 'release'
645375b 
* release: (41 commits)
  chore(release): 4.0.0 [skip ci]
  ci: release commit
  chore(release): 4.0.0-beta.2 [skip ci]
  fix: various UI bugs (e.g. filter data browser, switch app, upload file) (parse-community#2014)
  chore(release): 4.0.0-beta.1 [skip ci]
  ci: release commit
  refactor: upgrade graphiql from 1.5.8 to 1.5.12 (parse-community#1971)
  refactor: upgrade otpauth from 7.0.7 to 7.0.8 (parse-community#1970)
  refactor: upgrade typescript from 4.4.4 to 4.5.2 (parse-community#1953)
  refactor: upgrade graphiql from 1.5.7 to 1.5.8 (parse-community#1968)
  ci: bump environment (parse-community#1966)
  refactor: upgrade graphiql from 1.5.5 to 1.5.7 (parse-community#1964)
  refactor: upgrade graphiql from 1.5.1 to 1.5.5 (parse-community#1963)
  chore(release): 4.0.0-alpha.5 [skip ci]
  fix: opening filter menu in data browser leads to blank page (parse-community#1958)
  refactor: upgrade graphql from 16.0.0 to 16.0.1 (parse-community#1955)
  refactor: use new React context API (parse-community#1948)
  refactor: use buttons instead of deprecated javascript URLs (parse-community#1940)
  refactor: upgrade webpack deps (parse-community#1939)
  chore(release): 4.0.0-alpha.4 [skip ci]
  ...

# Conflicts:
#	package-lock.json
#	src/dashboard/Data/Jobs/JobEdit.react.js
#	src/dashboard/Data/Jobs/Jobs.react.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damianstasik @parseplatformorg @404-html @mtrezza @visualfanatic